chore(greenhouse): makes route search validation Zod v4–ready (filter by prefix before parse) and upgrade zod to v4 #1446
+197
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 515d61a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hodanoori
changed the title
Contributor
|
hodanoori
changed the title
taymoor89
reviewed
Feb 11, 2026
taymoor89
reviewed
Feb 11, 2026
Contributor
taymoor89
left a comment
taymoor89
left a comment
There was a problem hiding this comment.
Because this zod update touches code as well let's add changeset to update patch version of the apps changed.
TilmanHaupt
reviewed
Feb 12, 2026
| /** | ||
| * Filters raw URL search params to only known keys and keys that start with any allowed prefix. | ||
| * Use this before Zod parsing when you need prefix-based catchall validation | ||
| * (Zod v4 no longer provides ctx.path in preprocess). |
Contributor
There was a problem hiding this comment.
Would not mention the zod version changes - not important after merge
TilmanHaupt
reviewed
Feb 12, 2026
| /** | ||
| * Filters raw URL search params to only known keys and keys that start with any allowed prefix. | ||
| * Use this before Zod parsing when you need prefix-based catchall validation | ||
| * (Zod v4 no longer provides ctx.path in preprocess). |
Contributor
There was a problem hiding this comment.
Would not mention the changes from zod 3 > 4.
TilmanHaupt
reviewed
Feb 12, 2026
| /** | ||
| * Filters raw URL search params to only known keys and keys that start with any allowed prefix. | ||
| * Use this before Zod parsing when you need prefix-based catchall validation | ||
| * (Zod v4 no longer provides ctx.path in preprocess). |
Contributor
There was a problem hiding this comment.
would not mention changes from zod3 > 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Route search validation no longer relies on Zod’s
ctx.pathinz.preprocess(removed in Zod v4). A small helper filters URL search params by known keys and allowed prefixes before parsing with Zod, so the same behavior works with Zod v3 and v4. Upgraded Zod from v3 to v4 (exact version 4.3.6).Changes Made
utils.ts), supernova (lib/utils.ts), doop (lib/helpers.ts), and greenhouse (lib/helpers.ts)./servicesand/vulnerabilitiesroutes to validate search via the helper + schema (no preprocess usingctx.path)./alertsroute to use the helper with ACTIVE_FILTERS_PREFIX and PAUSED_FILTERS_PREFIX./violationsroute to use the helper with ACTIVE_FILTERS_PREFIX./admin/plugin-presetsroute to use the helper with SELECTED_FILTER_PREFIX (Zod v4–compatible).getFiltersForUrlasRecord<string, string | string[]>and adjusted implementation so search param types align with the route schema.instanceof Errorand fallback for empty message) and in doop/supernova validate-search return values.ctx.path.Related Issues
Screenshots (if applicable)
none
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.